Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix container template names in docs #1703

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix container template names in docs #1703

merged 1 commit into from
Oct 28, 2024
+4 −4

Conversation

HeavyWombat
Copy link
Contributor

Changes

Fix wrong environment variable names in container template docs.

/kind cleanup

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@HeavyWombat
Fix container template names in docs
34226bd 
Fix wrong environment variable names in container template docs.

Signed-off-by: Matthias Diester <[email protected]>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2024
@openshift-ci openshift-ci bot added release-note-none Label for when a PR does not need a release note kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 28, 2024
SaschaSchwarze0
SaschaSchwarze0 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@SaschaSchwarze0 SaschaSchwarze0 added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 28, 2024
@SaschaSchwarze0 SaschaSchwarze0 merged commit 22cce02 into main Oct 28, 2024
14 of 22 checks passed
@SaschaSchwarze0 SaschaSchwarze0 deleted the fix/docs branch October 28, 2024 16:34
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.14.0 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@apoorvajagtap apoorvajagtap Awaiting requested review from apoorvajagtap

@qu1queee qu1queee Awaiting requested review from qu1queee

Assignees

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Shipwright Overview
Status: Done
Milestone
release-v0.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HeavyWombat @SaschaSchwarze0