Configure commit author, signing and signoff in GitHub action for image updates #1698
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The GitHub action we are using to create a pull request is distinguishing author and committer of the commit it creates. See https://github.com/peter-evans/create-pull-request/tree/v7/?tab=readme-ov-file#action-inputs
In #1692, the author is somehow the openshift-merge-robot.
Based on the action documentation, the author is taken from github.actor.
Based on https://github.com/orgs/community/discussions/25067, github.actor for a workflow run triggered by a schedule is the latest user that modified the schedule trigger. In our case that is the openshift-merge-robot because it merges our PRs including the PR that introduced or modified the GitHub action.
I am hereby changing the action configuration to use the GitHub Actions Bot also as author.
In addition, I am enabling commit signing and the sign-off in the commit message so that DCO can pass.
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes