Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure commit author, signing and signoff in GitHub action for image updates #1698

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Oct 27, 2024

Changes

The GitHub action we are using to create a pull request is distinguishing author and committer of the commit it creates. See https://github.com/peter-evans/create-pull-request/tree/v7/?tab=readme-ov-file#action-inputs

In #1692, the author is somehow the openshift-merge-robot.

Based on the action documentation, the author is taken from github.actor.

Based on https://github.com/orgs/community/discussions/25067, github.actor for a workflow run triggered by a schedule is the latest user that modified the schedule trigger. In our case that is the openshift-merge-robot because it merges our PRs including the PR that introduced or modified the GitHub action.

I am hereby changing the action configuration to use the GitHub Actions Bot also as author.

In addition, I am enabling commit signing and the sign-off in the commit message so that DCO can pass.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@SaschaSchwarze0 SaschaSchwarze0 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 27, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.14.0 milestone Oct 27, 2024
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Oct 27, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2024
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-github-action-commit-author branch from 33b4c79 to 144976b Compare October 27, 2024 19:55
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-github-action-commit-author branch from 144976b to 46d17d8 Compare October 28, 2024 16:37
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
Copy link
Contributor

openshift-ci bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HeavyWombat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6049152 into shipwright-io:main Oct 29, 2024
19 checks passed
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-github-action-commit-author branch October 29, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants