Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issues workflow and clean up repository #1353

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Add issues workflow and clean up repository #1353

merged 1 commit into from
Aug 9, 2023

Conversation

coreydaley
Copy link
Contributor

@coreydaley coreydaley commented Aug 8, 2023

Changes

  • Add .github/workflows/issues.yml
  • Remove files that are now hosted in the .github repository
  • Remove outdated 2021-roadmap.md file

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

 - Add .github/workflows/issues.yml
 - Remove files that are now hosted in the .github repository
 - Remove outdated 2021-roadmap.md file
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Aug 8, 2023
@openshift-ci openshift-ci bot requested review from otaviof and qu1queee August 8, 2023 14:52
@coreydaley
Copy link
Contributor Author

/assign @qu1queee @SaschaSchwarze0 ptal

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

@coreydaley: GitHub didn't allow me to assign the following users: ptal.

Note that only shipwright-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @qu1queee @SaschaSchwarze0 ptal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coreydaley
Copy link
Contributor Author

/kind cleanup

@openshift-ci openshift-ci bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 8, 2023
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Comment on lines +4 to +10
issues:
types:
- opened
pull_request_target:
types:
- opened
- reopened
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We (Enrique and myself) were wondering on this detail today. Do we need reopened for issues as well ? And do we really want pull requests in the projects ?

fyi @qu1queee

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like being able to look at the pull requests in the project, you can filter by is:pr or is:issue, since all pull requests might not have an issue associated with them. I think it helps ensure that pull requests don't get accidentally ignored or missed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, in that case this was the right decision!

@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Aug 8, 2023
@openshift-ci openshift-ci bot added release-note-none Label for when a PR does not need a release note and removed release-note Label for when a PR has specified a release note labels Aug 8, 2023
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit d313df6 into shipwright-io:main Aug 9, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants