Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHIP-0038: Release Branch Workflows #3

Merged

Conversation

adambkaplan
Copy link
Member

@adambkaplan adambkaplan commented Mar 11, 2024

Changes

Creating a reusable GitHub Actions workflow to set up release branches in Shipwright projects, and a corresponding starter workflow template. These workflows will let Shipwright projects opt into setting up release branches for project artifacts. The workflows allow branches to be created at specific git references, allowing release branches to be set up retroactively.

Partially implements shipwright-io/community#85
Proposal PR: shipwright-io/community#194

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Creating a reusable GitHub Actions workflow to set up release branches
in Shipwright projects, and a corresponding starter workflow template.
These workflows will let Shipwright projects opt into setting up
release branches for project artifacts. The workflows allow branches to
be created at specific git references, allowing release branches to be
set up retroactively.

Signed-off-by: Adam Kaplan <[email protected]>
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 11, 2024
workflow-templates/release-branch.properties.json Outdated Show resolved Hide resolved
workflow-templates/release-branch.yml Outdated Show resolved Hide resolved
- Fix copy/paste issue in starter workflow name
- Ensure the git-ref is always populated when creating a release branch

Co-authored-by: Sascha Schwarze <[email protected]>
@adambkaplan
Copy link
Member Author

Suggestions added. Note that we don't have Prow configured on this repo - those with write permission can merge PRs.

@adambkaplan adambkaplan added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 19, 2024
@SaschaSchwarze0 SaschaSchwarze0 merged commit cab20f2 into shipwright-io:main Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants