fix active model *_previously_changed? and active record will_save_change_to_*? and saved_change_to_*? dirty methods to accept kwargs
#639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since Rails 6.1 they accept kwargs `from` and `to`, see rails/rails@a6841c7
doits
force-pushed
the
fix_previously_changed
branch
from
afc5e7d
to
bb18d5b
Compare
… too like the Rails original methods do since Rails 6.1, see: - https://github.com/rails/rails/blob/6-1-stable/activerecord/lib/active_record/attribute_methods/dirty.rb#L51 - https://github.com/rails/rails/blob/6-1-stable/activerecord/lib/active_record/attribute_methods/dirty.rb#L101
doits
changed the title
*_previously_changed? dirty methods to accept kwargs*_previously_changed? and active record will_save_change_to_*? and saved_change_to_*? dirty methods to accept kwargs
|
❤️ thank you! |
shioyama
added a commit
that referenced
this pull request
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since Rails 6.1 they accept kwargs
fromandto, see rails/rails@a6841c7