Fix oflow bound in exp and pow. #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue shibatch#600 highlighted a limit of current implementation where early overflow is noticed, which diverges from the C99 standard. This patch adds test to catch this type of cases. It only checks a few points therefore we don't know for sure if overflow occurs at the right time but we know if something is wrong in the overflow region. Fix both scalar and simd implementation (double precision) Fixes shibatch#523.
|
Merging this PR. As it fixes both exp and pow. Will create a new issue for the pre-existing inaccuracies pointed out in pow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
What is the purpose of this pull request?
What changes did you make?
This PR consists in updating overflow threshold used in exp and pow.
Does this PR relate to any existing issue?
Fixes #523.
Relates to #600.