Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket Sorting Added #687

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Saurav-IIITU
Copy link

@Saurav-IIITU Saurav-IIITU commented Oct 21, 2023

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. Your PR title can be also used here.

Types of changes

What types of changes does your content introduce to this project?
Put an x in the boxes that apply (without "`")

  • Proofreading (fix spelling, grammar, punctuation, accuracy) Proofreading
  • New content (new section, new readme, etc.)
  • Modifications (modifying existing content)
  • Other (please describe)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. Don't hesitate to ask if you're unsure about any of them. We're here to help! This simply reminds us of what we will look for before merging your code.
Note: If you submit code make sure to test it

  • Tested any code that was added/modified in this PR
  • Added external links
  • Added internal links
  • Added images
  • Added videos
  • Added code snippets

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Adding your name to the contributor's list

Comment "@all-contributors please add @your_username for content" to add your name to the contributor's list.
You can change the "content" with any of this

Reviewers:

  • @username

Please ensure that you are not adding any sensitive information like API keys, secrets, passwords, tokens, usernames, or other credentials. Refrain from adding your name, email, or other personal information.

@the-label-bot the-label-bot bot added kind/documentation kind/documentation size/L size/L labels Oct 21, 2023
@the-label-bot
Copy link

the-label-bot bot commented Oct 21, 2023

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind documentation 0.861 ✔️
Size L 0.968 ✔️

@shhossain
Copy link
Owner

@Saurav-IIITU fix the errors.

(5, 'Algorithms/Sorting/Bucket Sort/readme.md | python code execution error in  54')
(5, 'Traceback (most recent call last):\n  File "f74111c4.py", line 23, in <module>\n    sorted_arr = bucket_sort(arr)\n  File "f74111c4.py", line 12, in bucket_sort\n    buckets[index].append(num)\nIndexError: list index out of range\n')
(5, 'README.md | python code execution error in  436')
(5, '  File "c6fa60c3.py", line 3\n    ```\n      ^\nIndentationError: unindent does not match any outer indentation level\n')
(5, 'Algorithms/Sorting/Bucket Sort/readme.md | go code execution error in  69')
Error: (5, '# command-line-arguments\n./a7[83](https://github.com/shhossain/computer_science/actions/runs/6598942253/job/17937596546?pr=687#step:10:84)4b10.go:5:2: imported and not used: "math"\n')
(5, 'Algorithms/Sorting/Bucket Sort/readme.md | ruby code execution error in  72')
(5, "9d1036ed.rb:2: syntax error, unexpected constant, expecting '}'\n    // Find the minimum and maximum valu...\n       ^~~~\n9d1036ed.rb:2: syntax error, unexpected `in', expecting end-of-input\n...e minimum and maximum values in the array\n...                             ^~\n")
(5, 'Algorithms/Sorting/Bucket Sort/readme.md | javascript code execution error in  66')
(5, "/home/runner/work/computer_science/computer_science/6ba031e9.js:25\n        buckets[index].push(arr[i]);\n                       ^\n\nTypeError: Cannot read properties of undefined (reading 'push')\n    at bucketSort (/home/runner/work/computer_science/computer_science/6ba031e9.js:25:24)\n    at Object.<anonymous> (/home/runner/work/computer_science/computer_science/6ba031e9.js:53:21)\n    at Module._compile (node:internal/modules/cjs/loader:1198:14)\n    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)\n    at Module.load (node:internal/modules/cjs/loader:1076:32)\n    at Function.Module._load (node:internal/modules/cjs/loader:[91](https://github.com/shhossain/computer_science/actions/runs/6598942253/job/17937596546?pr=687#step:10:92)1:12)\n    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)\n    at node:internal/main/run_main_module:22:47\n")
(5, 'Algorithms/Sorting/Bucket Sort/readme.md | c code execution error in  60')
(5, 'Segmentation fault (core dumped)\n')
(5, 'Algorithms/Sorting/Bucket Sort/readme.md | java code execution error in  63')
(5, 'Exception in thread "main" java.lang.IndexOutOfBoundsException: Index 6 out of bounds for length 6\n\tat java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)\n\tat java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)\n\tat java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)\n\tat java.base/java.util.Objects.checkIndex(Objects.java:361)\n\tat java.base/java.util.ArrayList.get(ArrayList.java:427)\n\tat BucketSort.bucketSort(BucketSort.java:23)\n\tat BucketSort.main(BucketSort.java:38)\n')
(5, 'Algorithms/Sorting/Bucket Sort/readme.md | cpp code execution error in  57')
(5, 'Segmentation fault (core dumped)\n')

@Saurav-IIITU
Copy link
Author

done please review

@shhossain
Copy link
Owner

There are errors in the code
82
(5, 'Algorithms/Sorting/Bucket Sort/readme.md | c code execution error in 60')
83
(5, 'Segmentation fault (core dumped)\n')

@WalterMarch WalterMarch mentioned this pull request Mar 1, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation kind/documentation size/L size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants