persist selected row #1135
persist selected row #1135
Conversation
There was a problem hiding this comment.
Hi @nthangeniphumudzo .This change is incorrect and doesn't fix the issue you mention.
I think the initial logic was to clear the selection when a user clicks outside the table, but in some cases it makes sense to keep the selection.
The change you proposed just moves the event handler and to a first table in the DOM.
If I understand correct this handler should be removed entirely, but if it's still required it should be attached to a correct DOM element, not to a first table, it will work incorrect if your page has multiple tables.
|
Thanks @IvanIlyichev for the insightful feedback. I will revise my implementation and communicate when I am done. |
|
Hi @IvanIlyichev . I have made use of useRef distinguish each table and use it to demacate the inside/outside of each table. Please kindly review and feedback . Thanks |
There was a problem hiding this comment.
Hi @nthangeniphumudzo. Row selection is handled wrong, I'll review it myself a bit later
Hi @IvanIlyichev . I was tasked to do this item. My changes are merely just making sure that we move away from the entire 'document' and just focus on the "table body" to avoid deSelect when clicking outside as per item stipulated.