Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI workflow #37

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix CI workflow #37

merged 1 commit into from
Jul 31, 2024

Conversation

janpieper
Copy link
Contributor

This PR is a try to fix the failing CI pipeline by using ubuntu-18.04 for old Elixir/OTP versions and ubuntu-latest for new versions.

Fixes #36

@janpieper
Copy link
Contributor Author

Hmmm, for some reason all legacy job steps are queued and for more than an hour now 🤷

Screenshot from 2024-07-29 09-57-20

@janpieper
Copy link
Contributor Author

@sheharyarn Do you know whether there is a limit of workflow steps or maybe the matrix is too big? 🤔 Or do you think we can maybe drop the legacy stuff and only use newer versions (>= 1.14)?

@sheharyarn
Copy link
Owner

sheharyarn commented Jul 30, 2024

Thank you for the PR!

Yes, I think we should drop the older versions including 1.14.

@janpieper
Copy link
Contributor Author

janpieper commented Jul 31, 2024

@sheharyarn I updated my changes to only change the versions to Elixir >= 1.14 and OTP >= 25.

The CI succeeded 💪

@sheharyarn sheharyarn merged commit f0eee3f into sheharyarn:master Jul 31, 2024
6 checks passed
@sheharyarn
Copy link
Owner

Awesome, thank you!

@janpieper janpieper deleted the fix-ci-workflow branch July 31, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is failing
2 participants