SHARD-1128: support removing NGTs thru single node's debug endpoint by using gossip #353
+199
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urnotsam
reviewed
Dec 16, 2024
|
reminder for myself: need to make this rotation safe |
| const devPublicKeys = getDevPublicKeys() // This should return list of public keys | ||
| const requestSig = reqParamsDropNGT.sig | ||
|
|
||
| if (reqParamsDropNGT.owner !== '') { |
There was a problem hiding this comment.
looks like logic in this condition and loop below is exactly the same... if so, could you move this in a method instead of duplicating the logic?
There was a problem hiding this comment.
after looking at the code closer, I remembered that theyre not actually exactly the same. There's a small difference. if you want, I can refactor it to make it more compact and avoid code duplication which wont be hard, but it is not as simple as putting it in a separate function
There was a problem hiding this comment.
I also dont like the code duplication, but because of the way the logic needed to be implemented, it was the simplest way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.