Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHARD-1137: Fix getTxTimestampBinary bucket size #349

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

SHARD-1137: Fix getTxTimestampBinary bucket size #349

wants to merge 9 commits into from
+23 −2

Conversation

mgthuramoemyint
Copy link
Contributor

No description provided.

urnotsam
urnotsam reviewed Dec 16, 2024
View reviewed changes
src/config/server.ts Outdated Show resolved Hide resolved
@jintukumardas
Copy link
Contributor

@mgthuramoemyint Phillip mentioned about adding the rate limit in the ticket: rate limit to no more than x requests per second per node , however, this is not included here. Are we planning to create a separate PR for this?

@mgthuramoemyint
Copy link
Contributor Author

@mgthuramoemyint Phillip mentioned about adding the rate limit in the ticket: rate limit to no more than x requests per second per node , however, this is not included here. Are we planning to create a separate PR for this?

The rate-limit in binary handler might need new design, out of scope for this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urnotsam urnotsam urnotsam left review comments

@aniketdivekar aniketdivekar aniketdivekar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgthuramoemyint @jintukumardas @aniketdivekar @urnotsam