SHARD-1058: Add per-IP connection limit to WebSocket server #97
+112
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S0naliThakur
requested review from
aniketdivekar,
jintukumardas,
mgthuramoemyint and
abdulazeem-tk4vr
aniketdivekar
previously approved these changes
Dec 26, 2024
urnotsam
reviewed
Dec 27, 2024
aniketdivekar
previously approved these changes
Dec 30, 2024
abdulazeem-tk4vr
requested changes
Dec 30, 2024
aniketdivekar
previously approved these changes
Dec 30, 2024
urnotsam
previously approved these changes
Dec 30, 2024
S0naliThakur
dismissed stale reviews from urnotsam and aniketdivekar
via
200ba92
S0naliThakur
force-pushed
the
perIPrateLimit
branch
from
b41a438 to
200ba92
Compare
…et removal for accurate tracking.
…tatus after connection closure. Update index.ts refactoring Add check to enforce a maximum connections limit
S0naliThakur
force-pushed
the
perIPrateLimit
branch
from
f6aae26 to
dddb5ae
Compare
urnotsam
approved these changes
Jan 2, 2025
aniketdivekar
approved these changes
Jan 3, 2025
abdulazeem-tk4vr
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear: https://linear.app/shm/issue/SHARD-1058
Summary:
maxConnectionsPerIPto limit the number of concurrent WebSocket connections from a single IP address.onConnectionfunction to check the number of active connections per IP and close the socket if the limit is reached.