SHARD-1147: Make heavy request limits configurable and enhance logging #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S0naliThakur
requested review from
aniketdivekar,
abdulazeem-tk4vr,
devendra-shardeum and
jintukumardas
aniketdivekar
approved these changes
Dec 30, 2024
abdulazeem-tk4vr
approved these changes
Dec 30, 2024
urnotsam
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear: https://linear.app/shm/issue/SHARD-1147
Summary:
Previously, setting config.rateLimitOption.allowedHeavyRequestPerMin to 61 or higher was ineffective because of the hard-coded rate limiting logic for heavy requests. This update removes those restrictions, making it easier to adjust heavy request thresholds as needed.