SEC-526 #118
Open
SEC-526 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulazeem-tk4vr
force-pushed
the
SEC-526
branch
from
dfa3dde to
4afa2ae
Compare
abdulazeem-tk4vr
force-pushed
the
SEC-526
branch
from
6dbe5e2 to
121a685
Compare
fix: add extractKeyFromTx function
chore : formatting fixes fix : add correct shardus-net branch
abdulazeem-tk4vr
force-pushed
the
SEC-526
branch
from
121a685 to
3813532
Compare
abdulazeem-tk4vr
force-pushed
the
SEC-526
branch
from
0642197 to
3813532
Compare
…unction to handle legacy and access list transactions
abdulazeem-tk4vr
force-pushed
the
SEC-526
branch
from
43124cc to
b1e3a03
Compare
| console.log('Execution Shard Key in receipt does not match the calculated key from transaction data.') | ||
| } | ||
| if (nestedCountersInstance) nestedCountersInstance.countEvent('receipt', 'executionShardKey mismatch') | ||
| executionShardKey = extractedKey |
There was a problem hiding this comment.
I wonder if fallback should be to the key which we received in receipt. Just in case our extraction logic has some flaws. We can discuss with design team.
| return response.accounts | ||
| } | ||
|
|
||
| throw new Error(`Secure account data not found on node ${node.ip}`) |
There was a problem hiding this comment.
can we add some logs here?if there is any error in response from /secure_accounts api, we lose the error message.
| @@ -0,0 +1,32 @@ | |||
| import * as fs from 'fs' | |||
There was a problem hiding this comment.
can this be written as unit test? what's the purpose of the file?
Also, filePath is hardcoded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear : https://linear.app/shm/issue/SEC-526/archiver-is-not-checking-list-of-accounts-belonging-to-actual-accounts