Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved UNet by s4627234 #486

Open
wants to merge 1 commit into
base: topic-recognition
Choose a base branch
from
Open

Improved UNet by s4627234 #486

wants to merge 1 commit into from

Conversation

DaveD123321
Copy link

Author: Jingming Dai

Student Number: s4627234 / 46272346

Description: Q1 in the COMP3710 report - ISIC dataset segmentation based on improved Unet.

Files :

modules.py source code of the components of model.

dataset.py data loader for loading and preprocessing data.

train.py source code for training, testing, validating, and saving model.

predict.py showing example of your model base on validation data.

README.MD document of project

images images of the results produced by the model

commit-history1, commit-history2, commit-history3 those lost commit history because of changes to commit branch

@shakes76
Copy link
Owner

This commit is so late that you will lose all marks, can you explain why it is late? Was there another PR you can reference? Please reply ASAP.

@shakes76 shakes76 added Improved UNet Ungraded Missing ident, so upload grade when found and removed Ungraded Missing ident, so upload grade when found labels Nov 20, 2022
@shakes76
Copy link
Owner

Good Practice (Design/Commenting, TF/Torch Usage)

Adequate use and implementation
Good spacing and comments
Header blocks missing -1

Recognition Problem

Solves problem
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage
Module present
Commenting
No Data leakage
Difficulty: Easy -10

Commit Log

Meaningful commit messages could be more descriptive -1
Progressive commits used

Documentation

ReadMe acceptable, could have had more info -1
Good Description and Comments
Markdown used PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
No Feedback required
Request Description good
LATE: Waiting for PR link from you to confirm marks above

@shakes76 shakes76 added the Ungraded Missing ident, so upload grade when found label Nov 21, 2022
@DaveD123321
Copy link
Author

DaveD123321 commented Nov 21, 2022 via email

@DaveD123321
Copy link
Author

DaveD123321 commented Nov 21, 2022 via email

@DaveD123321
Copy link
Author

DaveD123321 commented Nov 21, 2022 via email •
edited
Loading

@DaveD123321
Copy link
Author

This commit is so late that you will lose all marks, can you explain why it is late? Was there another PR you can reference? Please reply ASAP.

I think you can find it on # 394 for my previous one

#394 (this is the link for my previous pull request)

https://github.com/DaveD123321/PatternFlow/tree/4274dd66a8d5574c76681bcbb6bc73eba265d108/recognition (this is the previous one with the branch I create by my self)

For the pull request, the only way I found to update from my topic_recognition to the given topic_recognition is to create a new branch, so that why I closed the last pull request and create this one to solve the feedback issue.

@shakes76
Copy link
Owner

Thanks, evidence has been provided. Marks updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Improved UNet Ungraded Missing ident, so upload grade when found
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaveD123321 @shakes76