Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run Spring in erb loader #141

Merged
merged 3 commits into from
Jun 5, 2022
Merged

Don't run Spring in erb loader #141

merged 3 commits into from
Jun 5, 2022

Conversation

tomdracz
Copy link
Collaborator

@tomdracz tomdracz commented Jun 5, 2022

Fixes #137

Reference usabilityhub/rails-erb-loader#63

Running rails-erb-loader through runner with spring enabled is likely to cause random issues and failures. This will now pass DISABLE_SPRING env to runner explicitly in order to skip Spring being used

@tomdracz tomdracz merged commit 226f5ba into master Jun 5, 2022
@tomdracz tomdracz deleted the fix-erb-loader-spring branch June 5, 2022 10:11
@justin808
Copy link
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't execute Rails Code in js.erb files
2 participants