Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Paused video doesn't react on changing device orientation #194

Open
kareljuricka opened this issue Nov 25, 2020 · 0 comments · May be fixed by #199
Open

Paused video doesn't react on changing device orientation #194

kareljuricka opened this issue Nov 25, 2020 · 0 comments · May be fixed by #199
Labels
type: bug Something isn't working correctly
Milestone

Comments

@kareljuricka
Copy link
Contributor

Issue description

I'm listening UIDevice.orientationDidChangeNotification to recalculate player view frame on orientation changed.
On each change, I call:

self.playerView.frame = self.view.bounds;

where self.playerView is ShakaPlayerView instance.

If video is PLAYING, this approach works correctly.

But when video is PAUSED, last image of paused video is rotated but its dimensions aren't recalculated..
Dimensions aren't recalculated until I start to play video again.

ScreenShot

After rotate from landscape to portrait when player paused:
Wrong behavior
IMG_7059

Expected behavior
IMG_7060

kareljuricka added a commit to kareljuricka/shaka-player-embedded that referenced this issue Nov 27, 2020
@TheModMaker TheModMaker added the type: bug Something isn't working correctly label Nov 30, 2020
kareljuricka added a commit to kareljuricka/shaka-player-embedded that referenced this issue Nov 30, 2020
@shaka-bot shaka-bot added this to the v1.1 milestone Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants