Fixing paused video doesn't react on changing device orientation

Fixes shaka-project#194
kareljuricka · Nov 27, 2020 · 581e317 · 581e317
1 parent 9fc1372
commit 581e317
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/shaka/src/media/apple_video_renderer.cc b/shaka/src/media/apple_video_renderer.cc
@@ -59,7 +59,8 @@ CGImageRef AppleVideoRenderer::Impl::Render(
   if (delay)
     *delay = loc_delay;
 
-  if (!frame || frame == prev_frame_)
+  const bool is_paused = player_->PlaybackState() == VideoPlaybackState::Paused;
+  if (!frame || (frame == prev_frame_ && !is_paused))
     return nullptr;
 
   if (sample_aspect_ratio)

diff --git a/shaka/src/media/video_renderer_common.h b/shaka/src/media/video_renderer_common.h
@@ -51,12 +51,13 @@ class VideoRendererCommon : public VideoRenderer, MediaPlayer::Client {
   struct VideoPlaybackQuality VideoPlaybackQuality() const override;
   bool SetVideoFillMode(VideoFillMode mode) override;
 
+ protected:
+  mutable Mutex mutex_;
+  const MediaPlayer* player_;
+
  private:
   void OnSeeking() override;
 
-  mutable Mutex mutex_;
-
-  const MediaPlayer* player_;
   const DecodedStream* input_;
   struct VideoPlaybackQuality quality_;
   std::atomic<VideoFillMode> fill_mode_;