Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StrErr support #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

StrErr support #2

wants to merge 2 commits into from

Conversation

random-ua
Copy link

No description provided.

@random-ua random-ua mentioned this pull request May 17, 2020
Closed
shaggy8871
shaggy8871 requested changes May 17, 2020
View reviewed changes
src/Console/StdOut.php Outdated Show resolved Hide resolved
src/Console/StdOut.php Outdated Show resolved Hide resolved
@shaggy8871
Copy link
Owner

Nice job, by the way.

@random-ua
Copy link
Author

Unit tests are failing - not sure what am I doing wrong

Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Console Application 1.0\n
-\n
-usage: ./vendor/bin/phpunit [command] [arguments]\n
-\n
-Commands:\n
-  app:simple\n
-\n
-'
+''

@random-ua random-ua requested a review from shaggy8871 May 18, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaggy8871 shaggy8871 Awaiting requested review from shaggy8871

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@random-ua @shaggy8871