Feat(QRCode): Enhance 'Scan QR Code From Screen' notifications # #1250 #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owsocks#1250 Improve the clarity of notifications in the QR code scanning feature: 1. Permission handling: - Show notification when screen recording permission is missing - Automatically open system settings for permission grant 2. Enhanced scanning status notifications: When no QR code found: - Title: "Scanned X displays" - Subtitle: "No QR codes found" - Body: "Try adjusting the QR code position on your screen" When invalid QR codes found: - Title: "Found X QR code(s)" - Subtitle: "No valid Shadowsocks URLs" - Body: "QR codes found are not Shadowsocks configuration" When valid QR codes found: - Title: "Found X Shadowsocks URL(s)" - Subtitle: "Scanned X displays, found X QR codes" - Body: "Successfully added X server configuration(s)"
|
Resolve invalid QR code scanning issue #1250 |
|
@lkebin I saw a recent PR mentioned you, Could you help review this PR? |
|
The following error was encountered during the CI build process: Makefile.am:21: error: Libtool library used but 'LIBTOOL' is undefined This seems to be a configuration issue with the build system and has nothing to do with my code changes. Should I resubmit the PR? |
lkebin
approved these changes
Oct 29, 2024
|
@lkebin Hi maintainers,Could you please help to re-run the workflow? I noticed the build failed due to some configuration issues, but I don't have the permissions to trigger a rebuild myself.Thank you for your time and code review! |
lkebin
reviewed
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the clarity of notifications in the QR code scanning feature:
Enhanced scanning status notifications: When no QR code found:
When invalid QR codes found:
When valid QR codes found: