docs: add react with vite installation guide #714
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
@samuelkurdz Thanks so much for creating the docs for this. Can we move it to |
I was thinking the same thing. It would be great to have tabs in the |
@shadcn Yes of course. {
title: "Installation",
href: "/docs/installation",
items: [
{
title: "React with vite",
href: "/docs/react-with-vite",
items: [],
},
],
},but it did not appear as such. |
|
@samuelkurdz Something like this:
|
|
@dan5py Is anyone on this? or can I? |
|
@samuelkurdz I don't think so, go ahead |
|
@dan5py I kind of have a decision between the page quick links by the right. 1. 
2. |
|
@samuelkurdz I think the first is cleaner. |
|
@dan5py PR updated. |
There was a problem hiding this comment.
You can remove the classnames from the components since they're already applied in mdx-component.tsx (also the wrapper div)
|
Done! |
|
@samuelkurdz This looks great. Question: do we want the following config in "baseUrl": ".",
"paths": {
"@/*": ["./src/*"]
}So that aliases such as Here's a CodeSandbox I was testing: https://codesandbox.io/p/sandbox/shadcn-ui-vite-m9ry84?file=%2Ftsconfig.json%3A8%2C22 |
|
Yeah, this would keep the same aliases for different frameworks. So I suggest keeping the - alias: [{ find: "src", replacement: path.resolve(__dirname, "./src/") }],
+ alias: [{ find: "@", replacement: path.resolve(__dirname, "./src/") }],And also the CLI prompts would remain the default ones: - Configure the import alias for components: › src/components
- Configure the import alias for utils: › src/lib/utils
+ Configure the import alias for components: › @/components
+ Configure the import alias for utils: › @/lib/utils |
|
@shadcn @dan5py Without that: This above created an By the way, this is my first open-source contribution. Thanks for being nice! |
Yeah I'm aware of this. Just add the paths on the |
Updated! |
No. Thank you. This is amazing! |
You did a really great job! 🎉 |
|
Really nice !!!!!! Thanks for supporting Vite :) |
|
Works really fine to me, and I added Dark mode guide for Vite: |
|
Hi @samuelkurdz, |
|
@samuelkurdz The new layout has been merged to main. You can now add the vite docs. Thanks in advance 💪. |
|
Awesome. Thanks so much @samuelkurdz |
* docs: add react with vite installation guide * refactor(docs): move Ract with vite page into installation.mdx as tab * fix(docs): remove classnames and wrapper divs * fix(docs): update tsconfig file path to default @ * docs(www): fix code style --------- Co-authored-by: Samuel Adebayo <[email protected]> Co-authored-by: shadcn <[email protected]>
* docs: add react with vite installation guide * refactor(docs): move Ract with vite page into installation.mdx as tab * fix(docs): remove classnames and wrapper divs * fix(docs): update tsconfig file path to default @ * docs(www): fix code style --------- Co-authored-by: Samuel Adebayo <[email protected]> Co-authored-by: shadcn <[email protected]>
No description provided.