Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjusted accordion trigger children so that asChild is working correctly #4323

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

domudev
Copy link

@domudev domudev commented Jul 17, 2024

  • Using asChild on AccordionTrigger previously caused an error: "React.Children.only expected to receive a single React element child." This happened because AccordionPrimitive.Trigger had two children, which triggered the error when asChild was used.
  • The issue is now resolved by ensuring there is only one child node. This single child node is used internally, making both approaches compatible.
  • The rotation and display of the chevron are now coupled to the asChild usage, and it works only for the predefined chevron.

Copy link

vercel bot commented Jul 17, 2024

@domudev is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant