feat: added support to change the design of a slider-thumb #4224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Fedox-die-Ente
changed the title
|
@Fedox-die-Ente hmm, I wonder if this is something you'd want to do frequently or once. If frequently, then the prop makes sense. If once per app (so that all slides share the same style), then I think you can change the slider.tsx file itself. |
shadcn
added
component: slider
postpone: more info or changes requested
Well, I could bet that someone in the future will say: "Hmmm, I need 2 different sliders on my site" xd |
KUNJ1311
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this pull requests give users the chance to edit the thumb of a slider via
thumbClassName