Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all issues related Command component #4154

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rudrodip
Copy link

@rudrodip rudrodip commented Jul 3, 2024

Fix Command Component issues and update documentation

Changes

  • Resolve Command Component issues by wrapping <CommandGroup /> inside <CommandList>
  • Update deprecated docs in combobox.mdx to reflect latest <Command /> component usage

Code Changes

From:

<Command>
  ...
  <CommandGroup>
    ...
  </CommandGroup>
</Command>

To:

<Command>
  ...
  <CommandList>
    <CommandGroup>
      ...
    </CommandGroup>
  </CommandList>
</Command>

Visual Comparison

Before & After comparison:

fix-command.mp4

Summary

By wrapping <CommandGroup /> inside <CommandList>{children}</CommandList>, all issues related to the Command Component have been resolved.

Copy link

vercel bot commented Jul 3, 2024

@rudrodip is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants