-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(blocks): wrap tooltip with tooltip provider #3472
base: main
Are you sure you want to change the base?
fix(blocks): wrap tooltip with tooltip provider #3472
Conversation
@aakash19here is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Can you please review this @ruru-m07 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aakash19here you can do this with another way also
you do not need to use TooltipProvider two times just wrap the full code like this.
still, the code works perfectly
but the best way to face this is to do something like this
Just use TooltipProvider in the app layout
I think you need to close this PR
resolve #3465 |
@aakash19here if you see shadcn-ui properly you will notice this ===> they also use TooltipProvider in layout |
by the way @aakash19here we never need to add +1,364 and remove −1,284 to fix this code we just fix this under two line |
Thankyou for the explanation @ruru-m07 🤝🏻 |
@aakash19here ❤️👍 |
This feels like it should be explained in the docs of the tooltip. |
Hi @ruru-m07, I appreciate your solution to the issue. However, every developer who wants to use the blocks affected by this bug (dashboard-05, dashboard-06, dashboard-07, dashboard-03) will need to search for the issue on GitHub and then find your solution. This is why I believe @aakash19here's approach is better, as it will fix the bug for everyone. Thank you! |
FIXES #3465
This PR wraps all the Tooltip components with ToolTipProvider