Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blocks): wrap tooltip with tooltip provider #3472

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aakash19here
Copy link
Contributor

FIXES #3465

This PR wraps all the Tooltip components with ToolTipProvider

Copy link

vercel bot commented Apr 13, 2024

@aakash19here is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@aakash19here
Copy link
Contributor Author

Can you please review this @ruru-m07

Copy link

@ruru-m07 ruru-m07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aakash19here you can do this with another way also

you do not need to use TooltipProvider two times just wrap the full code like this.

image

still, the code works perfectly

image

but the best way to face this is to do something like this

image

Just use TooltipProvider in the app layout

I think you need to close this PR

@ruru-m07
Copy link

resolve #3465

@ruru-m07
Copy link

@aakash19here if you see shadcn-ui properly you will notice this ===>

image

they also use TooltipProvider in layout

@ruru-m07
Copy link

by the way @aakash19here we never need to add +1,364 and remove −1,284 to fix this code we just fix this under two line

image

@aakash19here
Copy link
Contributor Author

Thankyou for the explanation @ruru-m07 🤝🏻

@ruru-m07
Copy link

ruru-m07 commented Apr 18, 2024

@aakash19here ❤️👍

@Christophvh
Copy link

This feels like it should be explained in the docs of the tooltip.

@walid1508
Copy link

Hi @ruru-m07,

I appreciate your solution to the issue. However, every developer who wants to use the blocks affected by this bug (dashboard-05, dashboard-06, dashboard-07, dashboard-03) will need to search for the issue on GitHub and then find your solution. This is why I believe @aakash19here's approach is better, as it will fix the bug for everyone.

Thank you!

@aakash19here aakash19here reopened this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Missing TooltipProvider in dashboard-7 block
4 participants