Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/microcosm-cc/bluemonday from 1.0.9 to 1.0.22 #200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 30, 2023

Bumps github.com/microcosm-cc/bluemonday from 1.0.9 to 1.0.22.

Release notes

Sourced from github.com/microcosm-cc/bluemonday's releases.

Add picture to list of elements allowed without attributes

This is not a security update!

This is a usability update as some HTML elements are valid without attributes however the default behaviour is to strip these out of an abundance of caution. The picture element https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture is one such element where it merely changes the browser rendering such that one of the child elements will be rendered.

The picture element was not present in the allowlist when it should have been, and so this release fixes that as per #161 .

Very minor bug fix to remove empty elements without attributes

Thanks to @​Gusted for microcosm-cc/bluemonday#151 which fixes a bug that allowed a policy to be defined in a way that input could've allowed an empty and meaningless element to be left in the output when it should not have done so.

This is not a security issue, and the details can be seen in the PR comment.

Updated x/net/html

This is an update of dependencies, specifically it updates the HTML parser within go/net/html.

The update removes a capability, Microsoft style comments that allow browser conditionals no longer works. This is due to a fix on the part of the Go team to prevent XSS within HTML comments, and the commit in question is here golang/net@06994584 . There is no easy to see safe way to restore that functionality without adding more risk to those who .AllowComments() and so I am accepting that this non-standard use of HTML comments is no longer supported.

As part of this version, the older release of v1.0.19 is retracted.

Add SVG inline images, improve RGB color and length matching, fix bug

What's Changed

  • css: improve RGB hex color and length matching by @​hochhaus in microcosm-cc/bluemonday#142
  • css: add support for image/svg+xml for data-uri inline images
  • html: fix double-escaping of content within HTML attributes
  • tests: added more tests to provide examples of proofs of some open issues

New Contributors

Full Changelog: microcosm-cc/bluemonday@v1.0.18...v1.0.19

Fix bug in iframe sandboxvalues

What's Changed

Full Changelog: microcosm-cc/bluemonday@v1.0.17...v1.0.18

Add support for the "sandbox" attribute on the "iframe" element

As per microcosm-cc/bluemonday#135 @​kiwiz has added support to bluemonday that allows the iframe element to correctly declare the security attribute sandbox.

You can read about that attribute here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#attr-sandbox

No other change is in this release.

Prevent a HTML sanitization vulnerability

CVE-2021-42576

A vulnerability was discovered by https://github.com/TomAnthony https://www.tomanthony.co.uk/ which allowed the contents of a style tag to be leaked unsanitized by bluemonday into the HTML output. Further it was demonstrated that if the form elements select and option were allowed by the policy that this could result in a successful XSS.

You would only be vulnerable to if if you allowed style, select and option in your HTML sanitization policy:

... (truncated)

Commits
  • fc539b0 Merge pull request #162 from microcosm-cc/buro9/161
  • ef72ac8 Add picture to allowlist of elements that do not need attributes to resolve #161
  • 1ee3c12 go mod && go fmt: update dependencies and format code
  • 07c5693 Merge pull request #151 from Gusted/self-closing-tag-bug
  • cc9997e Don't write self-closing tag with empty attributes
  • 705c34a Updated x/net/html to ensure latest version from the Go team, retracted v1.0....
  • 84409dd Only test n-1 Go versions
  • 8fc9802 Merge branch 'main' of github.com:microcosm-cc/bluemonday into main
  • c66f9ff Updated Go version, retract old versions of this package which are always con...
  • a232bac Removed outdated build badge
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/microcosm-cc/bluemonday](https://github.com/microcosm-cc/bluemonday) from 1.0.9 to 1.0.22.
- [Release notes](https://github.com/microcosm-cc/bluemonday/releases)
- [Commits](microcosm-cc/bluemonday@v1.0.9...v1.0.22)

---
updated-dependencies:
- dependency-name: github.com/microcosm-cc/bluemonday
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #200 (5e43331) into master (cf61161) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage   15.44%   15.38%   -0.06%     
==========================================
  Files          24       24              
  Lines        1716     1716              
==========================================
- Hits          265      264       -1     
  Misses       1400     1400              
- Partials       51       52       +1     
Flag Coverage Δ
unittests 15.38% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/sgtm/http_server.go 66.39% <0.00%> (-0.41%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants