removed prefix from suppression strings and added suppression tests #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -41,39 +42,73 @@ public void setN(int n) {} | |||
| * A class in which a single javax.inject.Qualifier annotation is on the class, on a constructor, | |||
| * on a field, on a method, and on a method parameter. | |||
| */ | |||
| @Foo | |||
| @Foo1 | |||
There was a problem hiding this comment.
Why did you change all of these to @Foo1?
There was a problem hiding this comment.
Hey sorry for the delay--I forgot to change my email settings to my personal account so didn't get the updates. Before I had the suppression tests, in the negative cases there was only a need to have one qualifier(and one BindingAnnotation) so I called it @Foo. But. when I added the suppression tests, I needed two qualifiers so that I could put two on and suppress the warnings. So I added a second qualifier and instead of having one named @Foo, I used @Foo1 and @Foo2. In the old tests where I only needed one qualifier, I used @Foo1.
|
Other than one question in a test, this is pretty awesome. |
|
PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.