Cleanup #13
Open
Cleanup #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.Adding testing utility method to makes test classes cleaner and refactored all test classes to use it. 2. Changed MultiMatcher to return the set when using ANY. This is a proposal, although no code currently uses it. I'd appreciate feedback on whether or not this is an improvement.
ghost
self-assigned this
| @@ -48,7 +48,7 @@ | |||
|
|
|||
| private static final String ASSISTED_ANNOTATION = "com.google.inject.assistedinject.Assisted"; | |||
|
|
|||
| private Matcher<VariableTree> constructorAssistedParameterMatcher = new Matcher<VariableTree>() { | |||
| private Matcher<VariableTree> ASSISTED_CONSTRUCTOR_MATCHER = new Matcher<VariableTree>() { | |||
There was a problem hiding this comment.
is this not final also? If not final, then it shouldn't be all-caps. If stateless and singular, then it shoudl be final.
|
This looks generally awesome, but I would get Eddie or Caitlin to check it out - you do some cleanups that seem like they make logical changes (Short circuited boolean checks, etc.) that I don't feel I know the system well enough to adequately assess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large changes:
1.Added testing utility method to makes test classes cleaner and
refactored all test classes to use it.
proposal, although no code currently uses it. I'd appreciate feedback on
whether or not this is an improvement.
Small changes: made some matchers static, added copyright header, a few small refactorings