Add support for holes in makeFace

sgenoud · Jan 8, 2024 · 2c8bc6a · 2c8bc6a
1 parent 4a4532b
commit 2c8bc6a
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/replicad/src/shapeHelpers.ts b/packages/replicad/src/shapeHelpers.ts
@@ -299,9 +299,12 @@ export const assembleWire = (listOfEdges: (Edge | Wire)[]): Wire => {
   return wire;
 };
 
-export const makeFace = (wire: Wire): Face => {
+export const makeFace = (wire: Wire, holes?: Wire[]): Face => {
   const oc = getOC();
   const faceBuilder = new oc.BRepBuilderAPI_MakeFace_15(wire.wrapped, false);
+  holes?.forEach((hole) => {
+    faceBuilder.Add(hole.wrapped);
+  });
   if (!faceBuilder.IsDone()) {
     faceBuilder.delete();
     throw new Error("Failed to build the face. Your wire might be non planar.");