Skip to content

Commit

Permalink
Fix mirror types
Browse files Browse the repository at this point in the history
  • Loading branch information
ahdinosaur authored and sgenoud committed Jul 12, 2024
1 parent 321fb91 commit 1b7caa3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/replicad/src/geomHelpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ export function translate(shape: TopoDS_Shape, vector: Point): TopoDS_Shape {

export function mirror(
shape: TopoDS_Shape,
inputPlane: Plane | PlaneName | Point,
origin: Point
inputPlane?: Plane | PlaneName | Point,
origin?: Point
): TopoDS_Shape {
const transformation = new Transformation();
transformation.mirror(inputPlane, origin);
Expand Down
2 changes: 1 addition & 1 deletion packages/replicad/src/shapes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ export class Shape<Type extends TopoDS_Shape> extends WrappingObj<Type> {
*
* @category Shape Transformations
*/
mirror(inputPlane: Plane | PlaneName | Point, origin: Point): this {
mirror(inputPlane?: Plane | PlaneName | Point, origin?: Point): this {
const newShape = cast(mirror(this.wrapped, inputPlane, origin));
this.delete();

Expand Down

0 comments on commit 1b7caa3

Please sign in to comment.