Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clean): add clean_language function #666

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

NoirTree
Copy link
Contributor

@NoirTree NoirTree commented Jun 29, 2021

Description

Implementation of clean_language as described in #664.

How Has This Been Tested?

By testing the default setting, specifying formats and changing knowledge bases.

Snapshots:

image
image
image
image
image

Checklist:

  • My code follows the style guidelines of this project
  • I have already squashed the commits and make the commit message conform to the project standard.
  • I have already marked the commit with "BREAKING CHANGE" or "Fixes #" if needed.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vizipi
Copy link

vizipi bot commented Jun 29, 2021

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

No other active qualified developers found to review these specific changes. You might consider involving more team members with these code segments.


Potential missing files from this Pull request

No files found with a 40% threashold :)
No commonly committed files found with a 40% threashold

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #666 (158ca07) into develop (c735cd9) will increase coverage by 0.20%.
The diff coverage is 93.96%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #666      +/-   ##
===========================================
+ Coverage    84.32%   84.52%   +0.20%     
===========================================
  Files          104      106       +2     
  Lines         9811    10010     +199     
===========================================
+ Hits          8273     8461     +188     
- Misses        1538     1549      +11     
Impacted Files Coverage Δ
dataprep/clean/clean_language.py 88.99% <88.99%> (ø)
dataprep/clean/__init__.py 100.00% <100.00%> (ø)
dataprep/tests/clean/test_clean_language.py 100.00% <100.00%> (ø)
dataprep/eda/correlation/compute/overview.py 99.24% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c735cd9...158ca07. Read the comment docs.

@NoirTree NoirTree force-pushed the clean_language branch 2 times, most recently from b5af897 to dede51f Compare July 10, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants