Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): Adding generation of connector configuration files #312

Draft
wants to merge 16 commits into
base: develop
Choose a base branch
from
Draft

feat(connector): Adding generation of connector configuration files #312

wants to merge 16 commits into from

Conversation

juandavidospina
Copy link
Contributor

Description

Adding functionality for generating data_connector configuration files from HTTP request examples. No dependencies are identified.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Unit testings using OpenLibrary API endpoint.
Test scenarios :

  • Malformed request example
  • Response received in a format different than JSON
  • Response status codes different than "200: OK:

Snapshots:

NA

Checklist:

  • My code follows the style guidelines of this project
  • I have already squashed the commits and make the commit message conform to the project standard.
  • I have already marked the commit with "BREAKING CHANGE" or "Fixes #" if needed.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dovahcrow dovahcrow force-pushed the develop branch 3 times, most recently from 44f201f to 0a27b8d Compare September 19, 2020 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant