Fix argument delegation of convenience functions. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The convenience functions now delegate the parameters they're called with to the temporary instantiation of the `TextLorem` class instead of the method calls, the latter of which don't have arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hoping to use the convenience functions with the same parameters as is possible when directly instantiating
TextLorem()objects, but I was surprised this doesn't work.i.e. this doesn't work:
whereas this does:
However, this looks like a mistake rather than intention, as the delegation of the parameters is already present in
__init__.py, only the parameters are handed over to the methods of theTextLoremclass, which don't take arguments.My changes make the former work as well, which is more convenient and very slightly easier to read for one-time usage.