Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle GZip-encoded Twitter API responses #549

Closed
wants to merge 1 commit into from

Conversation

kennym
Copy link

@kennym kennym commented Apr 3, 2014

This PR does not include any spec coverage/documentation. I am asking for guidance on how to write a spec for this. Can you give me any hints?

@kennym
Copy link
Author

kennym commented Apr 3, 2014

Fixes #547, #548 and #473

@kennym
Copy link
Author

kennym commented Apr 3, 2014

/cc @sferik

@kennym kennym changed the title Handle GZip-encoded Twitter API responses. References #548 Handle GZip-encoded Twitter API responses Apr 3, 2014
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) when pulling 11736f4 on kennym:gzip-fix into 7b40188 on sferik:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.28%) when pulling 11736f4 on kennym:gzip-fix into 7b40188 on sferik:master.

@paracycle
Copy link
Collaborator

@kennym I believe this issue is actually caused by a bad monkey-patch in another gem (most likely right_aws or right_http_connection). See arsduo/koala#346 for a similar issue and resolution.

As it currently stands, IMHO, it doesn't look like the onus is on this gem to rectify what is broken by another gem.

@kennym
Copy link
Author

kennym commented Apr 3, 2014

@paracycle ha, that makes sense. I will check if that's the case.

@kennym
Copy link
Author

kennym commented Apr 3, 2014

@paracycle something tells me the culprit lies within: https://github.com/rightscale/right_http_connection/blob/master/lib/base/net_fix.rb

This is why nobody should never ever use a gem with monkey patched base classes on a global scope.

@kennym kennym closed this Apr 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants