Remove broken discovery sites #1005
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnveach
reviewed
Apr 12, 2023
| <feature | ||
| id="com.github.sevntu.checkstyle.checks.feature" | ||
| label="Extension for eclipse-cs plugin with additional Checks" | ||
| version="1.44.1"> |
There was a problem hiding this comment.
I can only assume the other changes are valid since I don't know, but I noticed when changing the formatting of these line were undone during a release by the release process. I don't know why they were, but I assume they have to remain as they were before unless we can disable the process that re-modified this file.
See #960
The release command that did this is mvn -e --no-transfer-progress clean install -f eclipse-pom.xml -Plocal-deploy.
| </url> | ||
|
|
||
| <plugin id="eclipsecs-sevntu-plugin" download-size="0" install-size="0" version="1.44.1" unpack="false"/> | ||
| <plugin | ||
| id="eclipsecs-sevntu-plugin" |
There was a problem hiding this comment.
Same with splitting this among multiple lines.
|
Test failure is commit message. I would rename commit to |
Discovery sites are used by the p2 installation system to discover additional update sites containing eclipse plugins and features. Adding arbitrary websites as discovery sites is an error and will lead to the Eclipse update mechanism trying to interpret those websites as update sites, failing, and then adding error messages in the log on each update.
Bananeweizen
force-pushed
the
remove_discovery_sites
branch
from
d615ac5
to
cfd1ebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovery sites are used by the p2 installation system to discover additional update sites containing eclipse plugins and features. Adding arbitrary websites as discovery sites is an error and will lead to the Eclipse update mechanism trying to interpret those websites as update sites, failing, and then adding error messages in the log on each update.