Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(model) support auto index fkey and setup relation on update a… #81

Merged
merged 28 commits into from
Oct 22, 2024

Conversation

vani-rf
Copy link
Contributor

@vani-rf vani-rf commented Oct 18, 2024

…nd on delete

Description

#74

New Feature

  • add auto index foreign key
  • add foreign key action on update
  • add foreign key action on delete

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Unit Tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

image

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 72.56858% with 110 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/supabase/drivers/local/meta/table.go 38.77% 21 Missing and 9 partials ⚠️
pkg/supabase/drivers/cloud/table.go 42.00% 20 Missing and 9 partials ⚠️
pkg/supabase/query/table.go 62.90% 22 Missing and 1 partial ⚠️
pkg/state/table.go 72.34% 6 Missing and 7 partials ⚠️
pkg/resource/tables/generate.go 75.67% 4 Missing and 5 partials ⚠️
pkg/resource/tables/print_diff.go 87.50% 4 Missing ⚠️
pkg/supabase/drivers/local/meta/indexes.go 77.77% 2 Missing ⚠️
Flag Coverage Δ
-race 71.61% <72.56%> (-0.87%) ⬇️
-tags "sonic avx" 71.58% <72.56%> (-0.87%) ⬇️
-tags go_json 71.62% <72.56%> (-0.81%) ⬇️
-tags nomsgpack 71.62% <72.56%> (-0.86%) ⬇️
go-1.21 71.52% <87.43%> (-0.33%) ⬇️
go-1.22 71.61% <72.56%> (-0.87%) ⬇️
macos-latest 71.62% <72.56%> (-0.86%) ⬇️
ubuntu-latest 71.62% <72.56%> (-0.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
model.go 100.00% <ø> (ø)
pkg/generator/model.go 82.50% <100.00%> (+2.84%) ⬆️
pkg/generator/storage.go 91.17% <100.00%> (-0.32%) ⬇️
pkg/resource/apply.go 61.30% <100.00%> (-1.61%) ⬇️
pkg/resource/import.go 80.89% <100.00%> (-1.18%) ⬇️
pkg/resource/load.go 100.00% <100.00%> (ø)
pkg/resource/tables/compare.go 76.41% <100.00%> (+6.66%) ⬆️
pkg/state/state.go 77.77% <ø> (-2.31%) ⬇️
pkg/supabase/drivers/cloud/indexes.go 100.00% <100.00%> (ø)
pkg/supabase/query/sql/index.go 100.00% <100.00%> (ø)
... and 9 more

... and 93 files with indirect coverage changes

@toopay toopay merged commit c9f3591 into main Oct 22, 2024
25 checks passed
@toopay toopay deleted the feature/model-fk-index branch October 22, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants