Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Is and Not* methods #80

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Add Is and Not* methods #80

merged 8 commits into from
Oct 17, 2024

Conversation

mul14
Copy link
Contributor

@mul14 mul14 commented Oct 16, 2024

Description

Add Is, NotIs, NotEq, NotNeq, NotLt, NotLte, NotGt, NotGte, NotIn, NotLike, and NotIlike methods.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Unit Tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 95.37037% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/db/where.go 95.23% 3 Missing and 2 partials ⚠️
Flag Coverage Δ
-race 72.45% <95.37%> (+0.25%) ⬆️
-tags "sonic avx" 72.48% <95.37%> (+0.29%) ⬆️
-tags go_json 72.42% <95.37%> (+0.22%) ⬆️
-tags nomsgpack 72.38% <95.37%> (+0.21%) ⬆️
go-1.21 71.82% <95.37%> (+0.34%) ⬆️
go-1.22 72.48% <95.37%> (+0.29%) ⬆️
macos-latest 72.47% <95.37%> (+0.27%) ⬆️
ubuntu-latest 72.50% <95.37%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/db/db.go 81.01% <100.00%> (+0.74%) ⬆️
pkg/db/where.go 96.77% <95.23%> (-0.93%) ⬇️

... and 1 file with indirect coverage changes

@toopay toopay merged commit f957776 into main Oct 17, 2024
30 checks passed
@toopay toopay deleted the feat/is-not branch October 17, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants