Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: remove return representation header #79

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

toopay
Copy link
Member

@toopay toopay commented Oct 14, 2024

Description

The preferred return representation interferes with RLS in some cases, making it difficult to optimize performance and leading to potential inconsistencies in certain scenarios.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
-race 72.24% <ø> (+0.04%) ⬆️
-tags "sonic avx" 72.23% <ø> (+0.08%) ⬆️
-tags go_json 72.23% <ø> (+0.03%) ⬆️
-tags nomsgpack 72.23% <ø> (+0.06%) ⬆️
go-1.21 71.56% <ø> (+0.03%) ⬆️
go-1.22 72.23% <ø> (+0.02%) ⬆️
macos-latest 72.25% <ø> (+0.03%) ⬆️
ubuntu-latest 72.24% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller.go 59.45% <ø> (+0.53%) ⬆️

... and 1 file with indirect coverage changes

@toopay toopay merged commit ad3d752 into main Oct 14, 2024
25 checks passed
@toopay toopay deleted the hotfix/remove-return-representation-header branch October 14, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants