Support Box<T>/Option<T> inside of non-JS value roots. #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
jdm
changed the title
4 tasks
sagudev
reviewed
Nov 9, 2024
Comment on lines
+172
to
+179
| impl<T> GCMethods for Option<T> { | ||
| unsafe fn initial() -> Self { | ||
| None | ||
| } | ||
|
|
||
| unsafe fn post_barrier(_v: *mut Self, _prev: Self, _next: Self) {} | ||
| } | ||
|
|
There was a problem hiding this comment.
Shouldn't we use bounds here (T: GCMethods) and call underlying methods (T::post_barrier)?
There was a problem hiding this comment.
Hmm, you're probably right. I'll take a look at how the C++ code handles similar situations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto_root! macro creates a CustomAutoRoot value for the provided initializer. When this initializer contains a Box, the code fails to compile because we don't have custom tracing code for boxes.