Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Challenge resolution #292

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

willcrisis
Copy link

A few notes

  • The expected-array.json file had an invalid syntax. I've fixed it in the first commit
  • The Google Search results page changed for artworks. There are two different implementations, one for the old design (lib/parsers/google_old_parser.rb) and one for the new design (lib/parsers/google_parser.rb)
  • I added a couple HTML files (directly saved from Chrome as a single HTML file) with a different search, and also added new *-expected-array.json files

How to run:

$ bundle install
$ bundle exec rspec spec/parser_spec.rb

@andypple83
Copy link
Contributor

Thanks @willcrisis, for submitting your solution. I've updated "Van Gogh paintings" example. Could you fix the code conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants