Finish challenge #291
Open
Finish challenge #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution Overview
The core idea of the solution is to implement a scraper that employs multiple strategies for parsing the image gallery displayed at the top of the search results page. Since Google may return different results for similar queries each strategy relies on specific selectors and is encapsulated within its own class.
Supported Cases
The solution currently handles the following cases:
Van Gogh Paintings (challenge case)
List of Popes (another type of carousel)
Red Hot Chili Peppers Members (grid)
Van Gogh Paintings (new request, another grid)
Commands
ruby scrape.rb- runs scraper on all html documents and saves results infilesdir.bundle exec rspec --color spec/scraper/knowledge_graph_spec.rb- runs tests