-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Update some versions #140
Conversation
e31db98
to
e17cdfc
Compare
@@ -9,13 +9,15 @@ Change log | |||
o'clock uses [PVP Versioning][1]. | |||
The change log is available [on GitHub][2]. | |||
|
|||
Unreleased | |||
1.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update this as well:
I updated the version number in
o-clock.cabal
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yep, actually I wanted to mark it as a draft while I'm messing with CI, but you were quite fast :D
I'll do it
8408ad3
to
6b8c406
Compare
Nothing too serious: * https://hackage.haskell.org/package/doctest-0.22.1/changelog * https://hackage.haskell.org/package/hedgehog-1.3/changelog * https://github.com/sol/markdown-unlit/commits/main * https://hackage.haskell.org/package/aeson-2.2.0.0/changelog * https://hackage.haskell.org/package/tasty-1.5/changelog Aeson changelog is quite big, but we use it only for a couple of simple instances.
Problem: CI uses old versions of stack and cabal, also tests our package with old GHCs. Solution: update stack and cabal to the latest ones, update GHC versions to support the latest 4. Also update `tested-with`.
Problem: TypeInType extension is deprecated since some recent GHC version, but we are using it. Solution: use DataKinds and PolyKinds instead as GHC suggests.
6b8c406
to
09bda57
Compare
Problem: due to ghc/ghc@13d627b we get different output in doctest for GHC 9.6 and 9.4. So with 9.6 they started to fail. Solution: force redundant promotion ticks for now. Add a comment that we should remove it when we stop supporting older GHCs. Another option would be to use CPP, but we already have 2 cases and supporting 3 cases sounds too verbose.
09bda57
to
28c65b7
Compare
Problem: Haddock CI step tries to build haddock for everything and fails to do it for doctest for an obscure reason. Solution: we don't really care about Haddock for anything besides the library, so the easiest solution seems to be to build Haddock only for the library, which is the default.
We removed `toNum` some time ago, now it seems to be ok to release it. Since it's a breaking change, we are increasing the middle version component.
28c65b7
to
415f1cc
Compare
Description
Boring PR that updates some upper bounds and version in CI config.
Related issue(s)
None
✅ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Public contracts
of Public Contracts policy.
and
Stylistic guide (mandatory)
✓ Release Checklist
o-clock.cabal
.under the "Unreleased" section to a new section for this release version.
I added
@since
haddock annotations.with a summary of all user-facing changes.
vX.Y.Z