Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility upgrade of chart()-function #31

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

serkor1
Copy link
Owner

@serkor1 serkor1 commented Aug 16, 2024

This is the first step towards an accessibility upgrade of {cryptoQuotes}. In this PR the following emergency patch has been implemented on the chart()-function:

  • The chart()-function now has a new option which controls the overall width of the chart.

Note

During the next couple of updates all documentation has to use correct alt text to increase accessibility of {cryptoQuotes}.

* The chart()-function now has a new option  which controls the overall width of the chart.

NEWS has been updated
PR #31 failed the checks. The source of the error:

* MEXC has changed the response-object on available tickers. This has been fixed.

All checks have passed.
@serkor1
Copy link
Owner Author

serkor1 commented Aug 16, 2024

The change in the chart()-function can be summarized as follows,

library(cryptoQuotes)
# default chart
chart(
  ticker = BTC,
  indicator = list(
    sma()
  ),
  sub    = list(
    macd()
  )
)

# with increased width
chart(
  ticker = BTC,
  indicator = list(
    sma()
  ),
  sub    = list(
    macd()
  ),
  options = list(
    width = 2
  ) 
)

Created on 2024-08-16 with reprex v2.1.0

@serkor1 serkor1 merged commit 31923a1 into development Aug 16, 2024
9 checks passed
@serkor1 serkor1 deleted the accessibility branch August 16, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant