Removed quantmod dependency

serkor1 · Oct 6, 2023 · 881baee · 881baee
1 parent 8eb9713
commit 881baee
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -11,6 +11,7 @@ Roxygen: list(markdown = TRUE)
 RoxygenNote: 7.2.3
 Suggests: 
     knitr,
+    quantmod,
     rmarkdown,
     testthat (>= 3.0.0)
 Config/testthat/edition: 3
@@ -20,7 +21,6 @@ Imports:
     jsonlite (>= 1.8.7),
     magrittr (>= 2.0.3),
     plotly (>= 4.10.2),
-    quantmod,
     rlang (>= 1.1.1),
     TTR,
     xts (>= 0.13.1),

diff --git a/NAMESPACE b/NAMESPACE
@@ -16,7 +16,6 @@ importFrom(plotly,add_annotations)
 importFrom(plotly,layout)
 importFrom(plotly,plot_ly)
 importFrom(plotly,subplot)
-importFrom(quantmod,HLC)
 importFrom(rlang,abort)
 importFrom(rlang,trace_back)
 importFrom(xts,as.xts)

diff --git a/R/chart.R b/R/chart.R
@@ -67,19 +67,18 @@ chart <- function(
     )
   )
 
-  # add Bollinger bands
   quote_ <- cbind(
     quote_,
     TTR::BBands(
-      HLC = quantmod::HLC(quote),
+      HLC = quote[,2:4],
       n = min(
         20,
         max(5, floor(nrow(quote_)/2))
-        )
       )
+    )
   )
 
-  suppressMessages(
+
     candlestick <- candlestick %>% plotly::add_lines(
       data = quote_,
       x = rownames(quote_),
@@ -108,7 +107,8 @@ chart <- function(
       ),
       inherit = FALSE
     )
-  )
+
+
 
 
   # 3) create volume

diff --git a/R/cryptoQuotes-package.R b/R/cryptoQuotes-package.R
@@ -10,7 +10,6 @@
 #' @importFrom plotly layout
 #' @importFrom plotly plot_ly
 #' @importFrom plotly subplot
-#' @importFrom quantmod HLC
 #' @importFrom rlang abort
 #' @importFrom rlang trace_back
 #' @importFrom TTR BBands

diff --git a/man/cryptoQuotes-package.Rd b/man/cryptoQuotes-package.Rd
diff --git a/vignettes/articles/01_intervals.Rmd → vignettes/articles/01-intervals.Rmd b/vignettes/articles/01_intervals.Rmd → vignettes/articles/01-intervals.Rmd
diff --git a/vignettes/articles/04_quantmod.Rmd → vignettes/articles/04-quantmod.Rmd b/vignettes/articles/04_quantmod.Rmd → vignettes/articles/04-quantmod.Rmd
@@ -15,7 +15,7 @@ library(cryptoQuotes)
 
 ### Introduction
 
-The ```cryptoQuotes``` package provides access to most major cryptocurrency exchanges around the world and it uses ```xts``` and ```zoo``` such that it seamlessly works with powerful packages like ```quantmod``` and ```ttr```.
+The ```cryptoQuotes``` package provides access to most major cryptocurrency exchanges around the world and it uses ```xts``` and ```zoo``` such that it seamlessly works with powerful packages like ```quantmod``` and ```TTR```.
 
 ### Charting using quantmod