Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aggregate's link in case of a boolean value #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix aggregate's link in case of a boolean value #26

wants to merge 1 commit into from

Conversation

jrRibeiro
Copy link
Contributor

@jrRibeiro jrRibeiro commented Apr 6, 2019

As per Sensu's documentation - https://docs.sensu.io/sensu-core/1.7/reference/checks/#check-attributes - named aggregates were only introduced in version 0.24.

NOTE: named aggregates are new to Sensu version 0.24, now being defined with a String data type rather than a Boolean (i.e. true or false). Legacy check definitions with "aggregate": true attributes will default to using the check name as the aggregate name.

If the aggregation attribute is set to true, an aggregation is created using the check's name.

This PR fixes an issue in Uchiwa, where an incorrect link is created, pointing to an (obviously un-existing) aggregation's page called true.

sensu

The fix is simply to point to the correct aggregation by using the check's name in the link if true is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant