Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify full certificate chain from remote host #66

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

demonfoo
Copy link

@demonfoo demonfoo commented Jun 4, 2020

Pull Request Checklist

Is this in reference to an existing issue?

#65

General

  • Update Changelog following the conventions laid out here

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass
    There's actually a test failure, but a) it's not related to the changes I made, and b) it was already there...

Purpose

To add expiration date checking for all certs in the supplied chain, not just the leaf cert.

Known Compatibility Issues

None.

@phumpal
Copy link
Contributor

phumpal commented Jun 5, 2020

Was thinking about adding this then came here. Glad I did. Works as expected!

@phumpal
Copy link
Contributor

phumpal commented Jul 1, 2020

Party time! 👍 💯 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants