Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utils] fixed design tokens colors lighten modifier #1500

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

msereniti
Copy link
Contributor

Motivation and Context

Design Tokens – a Figma plugin that we use in design to manage design tokens. It has colors modifiers that a works... in non trivial way. Our first implementation was using different formulas. New formulas does exactly same calculations like Design Tokens plugin.

How has this been tested?

I have checked that values computed now are exactly the same to the computed by design tokens plugin.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly or it's not required.
  • Unit tests are not broken.
  • I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • I have added new unit tests on added of fixed functionality.

@msereniti msereniti merged commit 227df15 into master Jul 10, 2024
9 checks passed
@msereniti msereniti deleted the utils-tokens-modifiers branch July 10, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants