Handle deletion of stale configuration files #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korowa
force-pushed
the
stale-files-deletion
branch
from
f71570e
to
bd8756f
Compare
Now at pre-configure stage, for each directory managed by the role, a task sequence is launched that lists checks for any difference between actual directory contents and expected list of files, and deletes any files not present in expected list. The behavior is controlled by `clickhouse_delete_stale_files` role variable, and enabled by default. Tested via emulation of stale config files presence (side-effect playbook) and additional run of the role on top of it.
korowa
force-pushed
the
stale-files-deletion
branch
from
bd8756f
to
a6a4281
Compare
azat
reviewed
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now at pre-configure stage, for each directory managed by the role, a task sequence is launched that lists checks for any difference between actual directory contents and expected list of files, and deletes any files not present in expected list.
The behavior is controlled by
clickhouse_delete_stale_filesrole variable, and enabled by default.Tested via emulation of stale config files presence (side-effect playbook) and additional run of the role on top of it.
Closes #22