Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for --check mode #26

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Add tests for --check mode #26

merged 2 commits into from
Nov 5, 2024

Conversation

korowa
Copy link
Collaborator

@korowa korowa commented Nov 4, 2024

Fix all tasks to be compatible with --check mode and adjust default molecule scenarios to run --check as well.

tasks/install_repo.yml Outdated Show resolved Hide resolved
handlers/main.yml Show resolved Hide resolved
@azat
Copy link
Collaborator

azat commented Nov 4, 2024

Now, can you also merge tests (#21) into your PR and see if this will work

@korowa korowa changed the base branch from cover-check-mode to main November 5, 2024 07:09
@korowa korowa force-pushed the test-check-mode branch 2 times, most recently from b0ccb6b to 5561db1 Compare November 5, 2024 08:20
In case check mode is running from the scratch, it'll fail due to
absent apt-repo / systemd service. The tasks requiring repo / systemd
service now contain custom failure/changed rules allowing the role
to be executed in check mode.
@azat azat changed the title Fix running the role in check mode from the scratch Add tests for --check mode Nov 5, 2024
@azat
Copy link
Collaborator

azat commented Nov 5, 2024

Thank you!

@azat azat merged commit b1ee146 into semrush:main Nov 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants