feat: allow for releasedLabels with successComment set to false #861
+239
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
reviewed
Jul 1, 2024
|
@gr2m done! |
gr2m
approved these changes
Jul 1, 2024
|
Hmm sorry some of the tests are failing, from the looks of it, it is most likely related to #857. Could you have a look? I'm sorry this is probably unrelated to your changes, I don't have time to look into it myself. Let us know if you don't have time either and we will get back to it another time |
Totally, maybe not today, but definitely this week. |
|
@gr2m it now works on my machine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title says, this PR allow you to set
successCommenttofalseand still get the labels.I recommend a review with whitespace changes hidden to reduce noise due to changes in indentation.
Oh, and I fixed
body->labelsfor posting labels: https://docs.github.com/en/rest/issues/labels?apiVersion=2022-11-28#add-labels-to-an-issue